Gitiles

review.gerrithub.io / DU-Final / packages_apps_BluetoothExt / 212539cdadebe147cc93d4050db6440d96e4d16e

commit | 212539cdadebe147cc93d4050db6440d96e4d16e | [log] [tgz] |
---|---|---|

author | László Dávid <laszlo.david@gmail.com> | Mon Oct 22 23:42:17 2012 +0200 |

committer | Steve Kondik <shade@chemlab.org> | Sun Sep 08 11:35:01 2013 -0700 |

tree | 9affdd871633f2c7b46c951eb5b161105fe650cb | |

parent | 9566c3e85e8c6349aae349ef1be874b4fbfc5a64 [diff] |

32 bit int shifted by 36 bits at BluetoothMasObexServer.getUint32BigEndian I have found the bug with the FindBugs tool (http://findbugs.sourceforge.net) The FindBugs description is: 32 bit int shifted by 36 bits at BluetoothMasObexServer.java:[line: 189] 32 bit int shifted by an amount not in the range 0..31 The code performs shift of a 32 bit int by a constant amount outside the range 0..31. The effect of this is to use the lower 5 bits of the integer value to decide how much to shift by (e.g., shifting by 40 bits is the same as shifting by 8 bits, and shifting by 32 bits is the same as shifting by zero bits). This probably isn't what was expected, and it is at least confusing. Bug kind and pattern: BSHIFT - ICAST_BAD_SHIFT_AMOUNT Change-Id: I45748b7e980c28a75a4210a8974aa00cd732e1f8

1 file changed

tree: 9affdd871633f2c7b46c951eb5b161105fe650cb