Gitiles
Code Review
Sign In
review.gerrithub.io
/
Articho28
/
addressbook-level2
/
4991eed1e64f4ebc1901e975ef6f768e77c5a45e
4991eed
Fix typo in VERSION string with incorrect spelling of AddressBook
by namjjd
· 6 years ago
de7ef4a
Command class: make non-abstract
by Damith C. Rajapakse
· 6 years ago
f94fe28
LearningOutcomes.md: tweak LOs to refer to se-book
by Damith C. Rajapakse
· 6 years ago
ad71877
[#204] README: update Contributors to refer to se-edu (#207)
by Zhi Yuan
· 6 years ago
a8cd67f
README: update Contributors to refer to se-edu
by eugenepeh
· 6 years ago
e7df84a
[#205] DeveloperGuide: Improve project setup instructions (#206)
by Tan Wang Leng
· 6 years ago
08e7bcd
[#202] Remove Eclipse project files (#203)
by Miao Ling
· 6 years ago
ae4464f
[#200] Migrate docs to use Intellij instead of Eclipse (#201)
by Miao Ling
· 6 years ago
1603ad0
[#191] runtest.sh: fix bug in deleting actual.txt from previous run (#192)
by Huang Chao
· 6 years ago
2d5071d
[#146] Run I/O tests in CI (#189)
by Huang Chao
· 6 years ago
816c503
Set theme jekyll-theme-cayman
by Damith C. Rajapakse
· 6 years ago
d238818
[#103] ParserTest: fix naming standard violation (#188)
by Kenneth Lu
· 6 years ago
c3c63de
[#144] Fix typo in header comment (#186)
by Miao Ling
· 6 years ago
4f5b987
[#169] Addressbook::addTag() is not used (#179)
by Damith C. Rajapakse
· 6 years ago
a6cc952
AddressBook: remove unused containsTag()
by PierceAndy
· 6 years ago
4e3fac9
UniqueTagList: remove unused remove()
by PierceAndy
· 6 years ago
fb8863d
AddressBook: remove unused removeTag()
by PierceAndy
· 6 years ago
84c8535
UniqueTagList: remove unused add()
by PierceAndy
· 6 years ago
419ec2b
AddressBook: remove unused addTag()
by PierceAndy
· 6 years ago
7492790
[#129] StorageFile class: load method should not create a new file (#142)
by Damith C. Rajapakse
· 6 years ago
adf4aef
Add unit test for loading non-existent files
by Tan Wang Leng
· 6 years ago
44ceadb
Remove creating new file on load()
by Tan Wang Leng
· 6 years ago
2ef44b2
Move handling of missing file to normal code path
by Tan Wang Leng
· 6 years ago
5810f7c
[#123] Set up checkstyle (#145)
by Damith C. Rajapakse
· 6 years ago
15b1751
Generate gradle wrapper
by Tan Wang Leng
· 6 years ago
a2b49d0
Fix checkstyle rule violations in tests
by Tan Wang Leng
· 6 years ago
c348297
Fix checkstyle rule violations in main classes
by Tan Wang Leng
· 6 years ago
8dfc604
Add checkstyle to gradle
by Tan Wang Leng
· 6 years ago
f92b1d0
[#111] Add unit tests for ViewAllCommand and ViewCommand classes (#131)
by Song Zhiwen
· 6 years ago
5e55b71
[#122] Add different levels of comparison to equality methods of Person class (#137)
by Dickson
· 6 years ago
7d0987d
[#112] Set up Travis CI (#140)
by Tan Wang Leng
· 6 years ago
07adaee
[#96] Phone::isValidPhone rephrase header comment (#141)
by MightyCupcakes
· 6 years ago
9b3434b
[#99] Rephrase method header comments to follow the convention (#139)
by MightyCupcakes
· 6 years ago
03e0b27
[#105] Add unit tests for AddressBook class (#121)
by Thenaesh Elango
· 6 years ago
70f60ba
[#117] Names with unicode characters are treated as invalid (#138)
by Neurrone
· 6 years ago
2fdb124
[#130] Change file extension requirement from .txt to .xml (#132)
by Song Zhiwen
· 6 years ago
a909e09
[#110] Add unit tests for FindCommand class (#120)
by awhdes
· 6 years ago
753fcc1
[#133] Test Failing due to incorrect message (#135)
by Song Zhiwen
· 6 years ago
24335db
[#104] Add unit tests for StorageFile class (#128)
by Song Zhiwen
· 6 years ago
1a15e66
[#107] Add unit tests for Utils class (#127)
by zzzzwen
· 6 years ago
7d1de69
[#124] Fix code style violation (#125)
by Tan Wang Leng
· 6 years ago
88133a6
[#108] Add unit tests for AddCommand class (#118)
by Neurrone
· 6 years ago
f196968
[#109] Add unit tests for DeleteCommand class (#119)
by Tan Wang Leng
· 6 years ago
7518552
[#102] Fix coding problem: reassigning parameters (#115)
by Jia Yee
· 6 years ago
43c506d
[#101] Remove unused imports (#114)
by Jia Yee
· 6 years ago
2283852
Add codacy badge
by Damith C. Rajapakse
· 7 years ago
c61e65b
[41] Name regex doesn't match hyphen, dots and quote
by ndt
· 7 years ago
02b59fc
encoding to UTF-8 w/o BOM for input and actual
by akshay narayan
· 7 years ago
8928fef
convert input and expected to UTF-8 encoding.
by akshay narayan
· 7 years ago
bf7f6bc
add more test case to test name with numbers (the latest fix)
by akshay narayan
· 7 years ago
adef5c6
fixed regex to "^[\\p{L}0-9 .'-]+$", the prev one did not have numbers
by akshay narayan
· 7 years ago
cec9204
add more tests to check for dash, dot, qote and unicode characters in the
by akshay narayan
· 7 years ago
c3ac0d5
Merge branch 'master' into fix-Name-regex
by akshay narayan
· 7 years ago
4070eff
Fix typo parse() --> parseCommand()
by Damith C. Rajapakse
· 7 years ago
4616995
Add blank line after bullet point
by Damith C. Rajapakse
· 7 years ago
e9f82ce
Refine negative example in LO-AssociationClass
by Damith C. Rajapakse
· 7 years ago
143ab5b
Add negative example for LO-AssociationClass
by Damith C. Rajapakse
· 7 years ago
397f0a8
Add reminder about refactoring to LO-TDD
by Damith C. Rajapakse
· 7 years ago
806840d
Use heading style for resources/side readings
by Damith C. Rajapakse
· 7 years ago
697328d
Add side reading 'Primitive Obsession' to LO doc
by Damith C. Rajapakse
· 7 years ago
371e577
Remove broken link Fixes #59
by Damith C. Rajapakse
· 7 years ago
35d0634
Add link to exception best practices
by Damith C. Rajapakse
· 7 years ago
c79722d
Add links to testing resources
by Damith C. Rajapakse
· 7 years ago
8b2ed36
Refine ParserTest with cosmetic tweaks
by Damith C. Rajapakse
· 7 years ago
730ea58
fix tests to clean up all entries before closing
by Akshay Narayan
· 7 years ago
db3978d
Update regex for better Name matching
by Akshay Narayan
· 7 years ago
19f22e0
Merge branch 'add-more-learning-outcomes'
by Damith C. Rajapakse
· 7 years ago
b3214f9
Fix typo in LO-Composition
by Damith C. Rajapakse
· 7 years ago
62d8777
Add a ToC to LO page
by Damith C. Rajapakse
· 7 years ago
c30df5e
Add LO-2KLoC
by Damith C. Rajapakse
· 7 years ago
4966713
Add LO-Composition
by Damith C. Rajapakse
· 7 years ago
e003983
Add LO-ClassLevel
by Damith C. Rajapakse
· 7 years ago
0cecda5
Add LO-TDD
by Damith C. Rajapakse
· 7 years ago
fbe33e9
Add LO-JUnit
by Damith C. Rajapakse
· 7 years ago
f5ad192
Add LO-AssociationClass
by Damith C. Rajapakse
· 7 years ago
eb97b47
Increase size of ReadOnlyPersonUsage.png
by Damith C. Rajapakse
· 7 years ago
4efbb68
Tweak images of LO-ISP
by Damith C. Rajapakse
· 7 years ago
bc6c9d8
Add LO-ISP
by Damith C. Rajapakse
· 7 years ago
1cf8f2f
Fix typo in ContactClassHierarchy.png
by Damith C. Rajapakse
· 7 years ago
ef504c6
Add LO-Inheritance
by Damith C. Rajapakse
· 7 years ago
52491ad
Remove Contact class from class diagram
by Damith C. Rajapakse
· 7 years ago
9b9c419
Make Command::getMessage.... method protected non-static
by Damith C. Rajapakse
· 7 years ago
e50426d
Fix composition-aggregation confusion in diagrams
by Damith C. Rajapakse
· 7 years ago
1ed45b7
regression test for #35
by Leow Yijin
· 7 years ago
8adfef8
[35] Fixed NPE when viewall used before list (PR #36)
by Leow Yijin
· 7 years ago
d4dcd8e
Fixes #34: typo in user guide add description
by Leow Yijin
· 7 years ago
e589263
Remove duplicate javac from test script
by Damith C. Rajapakse
· 7 years ago
10edaa7
Set exec permission bit on runtests.sh
by ndt
· 7 years ago
6868731
[32] Add runtests.sh
by ndt
· 7 years ago
a3ce74d
Add space and Change execution permission
by Joel Foo
· 7 years ago
b0aabaa
Update runtests.sh
by Joel Foo
· 7 years ago
83be2d7
Add runtests.sh
by jaeoheeail
· 7 years ago
9a10673
Add 'cloning' to setup instructions
by Damith C. Rajapakse
· 7 years ago
3fcadc4
Update test script to clean up at start
by Damith C. Rajapakse
· 7 years ago
c4331a1
Reorder LOs
by Damith C. Rajapakse
· 7 years ago
4af197d
Add more LOs
by Damith C. Rajapakse
· 7 years ago
ecbd119
Add LO-SRP
by Damith C. Rajapakse
· 7 years ago
be0f8ae
Adjust width
by Damith C. Rajapakse
· 7 years ago
f77367d
Add LO-ImplementClass
by Damith C. Rajapakse
· 7 years ago
8aeb68b
Fix broken link to setting up instructions (use relative path)
by Damith C. Rajapakse
· 7 years ago
Next »